You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds code for aggregate bloom filters. It doesn't do anything useful with the code, but under a conditional flag it will compare the results obtained from aggregate bloom filters with results obtained from regular bloom filters to ensure that the implementation is correct.
The bit matrix is implemented manually because somehow it's 10x faster this way than using the bitvec crate and also it's extremely simple. I have a hunch that we could get even more improvements if we used u32 instead of u8 to back the bit matrix. But this can be done later.
The next PR will implement storing these aggregate filters in the DB, and then the final PR will implement actually using them from the RPC calls (and finally reaping the benefits).
I have a hunch that we could get even more improvements if we used u32 instead of u8 to back the bit matrix. But this can be done later.
However, the problem with this is that we still store/load Vec<u8> from the DB, and converting that to Vec<u32> safely requires copying. So it may actually turn out to be slower.
I have a hunch that we could get even more improvements if we used u32 instead of u8 to back the bit matrix. But this can be done later.
However, the problem with this is that we still store/load Vec<u8> from the DB, and converting that to Vec<u32> safely requires copying. So it may actually turn out to be slower.
If the copying happens only once it shouldn't have any impact.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sistemd
force-pushed
the
sistemd/aggregate-bloom-filters
branch
from
This PR adds code for aggregate bloom filters. It doesn't do anything useful with the code, but under a conditional flag it will compare the results obtained from aggregate bloom filters with results obtained from regular bloom filters to ensure that the implementation is correct.
The bit matrix is implemented manually because somehow it's 10x faster this way than using the
bitveccrate and also it's extremely simple. I have a hunch that we could get even more improvements if we usedu32instead ofu8to back the bit matrix. But this can be done later.The next PR will implement storing these aggregate filters in the DB, and then the final PR will implement actually using them from the RPC calls (and finally reaping the benefits).